Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[ML] Fixing job management expanded rows in dark mode #45159

Merged
merged 2 commits into from
Sep 9, 2019
Merged

[ML] Fixing job management expanded rows in dark mode #45159

merged 2 commits into from
Sep 9, 2019
+6 −6

Conversation

jgowdyelastic
Copy link
Member

@jgowdyelastic jgowdyelastic commented Sep 9, 2019 •
edited
Loading

Using eui colors for the expanded row sections.

Currently hard coded colors are unreadable in dark mode
image

New colors:
Dark
image

Light
image

@jgowdyelastic jgowdyelastic added bug Fixes for quality problems that affect the customer experience review release_note:fix :ml v8.0.0 v7.4.0 v7.5.0 labels Sep 9, 2019
@jgowdyelastic jgowdyelastic requested a review from a team as a code owner September 9, 2019 15:54
@jgowdyelastic jgowdyelastic self-assigned this Sep 9, 2019
@elasticmachine
Copy link
Contributor

Pinging @elastic/ml-ui

walterra
walterra approved these changes Sep 9, 2019
View reviewed changes
Copy link
Contributor

@walterra walterra left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

peteharverson
peteharverson approved these changes Sep 9, 2019
View reviewed changes
Copy link
Contributor

@peteharverson peteharverson left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@elasticmachine
Copy link
Contributor

💚 Build Succeeded

alvarezmelissa87
alvarezmelissa87 approved these changes Sep 9, 2019
View reviewed changes
Copy link
Contributor

@alvarezmelissa87 alvarezmelissa87 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGMT ⚡️

@jgowdyelastic jgowdyelastic merged commit 997030b into elastic:master Sep 9, 2019
@jgowdyelastic jgowdyelastic deleted the fixing-jobs-list-in-dark-mode branch September 9, 2019 18:11
jgowdyelastic added a commit to jgowdyelastic/kibana that referenced this pull request Sep 9, 2019
@jgowdyelastic
[ML] Fixing job management expanded rows in dark mode (elastic#45159)
b72319c 
* [ML] Fixing job management expanded rows in dark mode

* changed in management too
This was referenced Sep 9, 2019
Merged
Merged
jgowdyelastic added a commit to jgowdyelastic/kibana that referenced this pull request Sep 9, 2019
@jgowdyelastic
[ML] Fixing job management expanded rows in dark mode (elastic#45159)
1475a5c 
* [ML] Fixing job management expanded rows in dark mode

* changed in management too
jgowdyelastic added a commit that referenced this pull request Sep 9, 2019
@jgowdyelastic
[ML] Fixing job management expanded rows in dark mode (#45159) (#45178)
3c34d4e 
* [ML] Fixing job management expanded rows in dark mode

* changed in management too
jgowdyelastic added a commit that referenced this pull request Sep 9, 2019
@jgowdyelastic
[ML] Fixing job management expanded rows in dark mode (#45159) (#45177)
452ffbd 
* [ML] Fixing job management expanded rows in dark mode

* changed in management too
@walterra walterra mentioned this pull request Oct 23, 2019
Closed
15 tasks
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@walterra walterra walterra approved these changes

@darnautov darnautov darnautov approved these changes

@alvarezmelissa87 alvarezmelissa87 alvarezmelissa87 approved these changes

@peteharverson peteharverson peteharverson approved these changes

Assignees

@jgowdyelastic jgowdyelastic

Labels
bug Fixes for quality problems that affect the customer experience :ml release_note:fix review v7.4.0 v7.5.0 v8.0.0
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
6 participants
@jgowdyelastic @elasticmachine @walterra @darnautov @alvarezmelissa87 @peteharverson